Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable resource status for telemetry resources #1453

Merged
merged 16 commits into from
Sep 25, 2024
Merged

feat: Enable resource status for telemetry resources #1453

merged 16 commits into from
Sep 25, 2024

Conversation

rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented Sep 17, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Remove feature flag KymaInputAllowed
  • Remove flag from telemetry manager controller
  • Allow e2e tests to run on non-dev version
  • update unit tests

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@rakesh-garimella rakesh-garimella requested a review from a team as a code owner September 17, 2024 12:10
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 17, 2024
@rakesh-garimella rakesh-garimella added this to the 1.24.0 milestone Sep 17, 2024
@rakesh-garimella rakesh-garimella added kind/feature Categorizes issue or PR as related to a new feature. area/metrics MetricPipeline area/ci Test automation labels Sep 17, 2024
@rakesh-garimella rakesh-garimella requested a review from a team as a code owner September 19, 2024 11:31
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2024
a-thaler
a-thaler reviewed Sep 19, 2024
View reviewed changes
docs/user/04-metrics.md Outdated Show resolved Hide resolved
@hisarbalik hisarbalik self-assigned this Sep 20, 2024
NHingerl
NHingerl reviewed Sep 23, 2024
View reviewed changes
docs/user/04-metrics.md Outdated Show resolved Hide resolved
docs/user/04-metrics.md Outdated Show resolved Hide resolved
docs/user/04-metrics.md Outdated Show resolved Hide resolved
docs/user/04-metrics.md Outdated Show resolved Hide resolved
docs/user/04-metrics.md Outdated Show resolved Hide resolved
docs/user/04-metrics.md Outdated Show resolved Hide resolved
@hisarbalik hisarbalik added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 24, 2024
@TeodorSAP TeodorSAP modified the milestones: 1.24.0, 1.25.0 Sep 24, 2024
hisarbalik
hisarbalik previously approved these changes Sep 24, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 24, 2024
nataliasitko
nataliasitko previously approved these changes Sep 25, 2024
View reviewed changes
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 25, 2024
@kyma-bot kyma-bot merged commit e3cd057 into kyma-project:main Sep 25, 2024
41 checks passed
@rakesh-garimella rakesh-garimella deleted the remove-module-status-feature-flag branch September 25, 2024 12:41
@NHingerl NHingerl mentioned this pull request Oct 7, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl left review comments

@a-thaler a-thaler a-thaler left review comments

@nataliasitko nataliasitko nataliasitko approved these changes

@hisarbalik hisarbalik hisarbalik approved these changes

Assignees

@hisarbalik hisarbalik

@nataliasitko nataliasitko

Labels
area/ci Test automation area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
7 participants
@rakesh-garimella @hisarbalik @a-thaler @NHingerl @nataliasitko @kyma-bot @TeodorSAP